fix: address remaining review findings

- Fix detail.html to use assigned_technician_name (not .assigned_technician?.full_name)
- Remove double error toast in submitNote() catch block
- Replace wasteful API calls in CEO dashboard with units+data approach
- Remove QR Code option from reported_via dropdown (excluded per scope)
This commit is contained in:
root
2026-07-23 19:18:17 +00:00
parent 5560496653
commit a9c17d0703
3 changed files with 17 additions and 10 deletions
+2 -2
View File
@@ -115,7 +115,7 @@
</div>
<div class="flex justify-between">
<dt class="text-sm text-gray-500">Assigned To</dt>
<dd class="text-sm font-medium text-gray-900" x-text="ticket.assigned_technician?.full_name || 'Unassigned'"></dd>
<dd class="text-sm font-medium text-gray-900" x-text="ticket.assigned_technician_name || 'Unassigned'"></dd>
</div>
<div class="flex justify-between">
<dt class="text-sm text-gray-500">Reporter</dt>
@@ -402,7 +402,7 @@
this.noteForm.note = '';
app().showToast('Note added', 'success');
} catch (e) {
app().showToast(e.message, 'error');
// No need to show error here — api() base method already shows it
} finally {
this.noteSubmitting = false;
}
+1 -1
View File
@@ -104,7 +104,7 @@
<option value="walk-in">Walk-in</option>
<option value="whatsapp">WhatsApp</option>
<option value="agent">Agent</option>
<option value="qr">QR Code</option>
<!-- QR Code excluded per Sprint 3 scope -->
</select>
</div>
</div>