no-mistakes(review): Fix review findings: test regression, contract verdict, scope trim

tests/test_mumuni_monitor_removal.py

@@ -98,8 +98,8 @@ exit 0
 """
 
 CURL_STUB = r"""#!/usr/bin/env bash
-# Stub curl: serve the Abiba health fixture and the Zulip server 200, and
-# record every call (including notify) payloads.
+# Stub curl: serve the Abiba health fixture, the Zulip server 200, and the
+# kagentz C3 public URL, and record every call (including notify) payloads.
 printf '%s\n' "$*" >> "$RECORD_DIR/curl.calls"
 case "$*" in
   *:9200/health*)
@@ -109,6 +109,8 @@ case "$*" in
     esac ;;
   *server_settings*)
     printf '%s' "$SERVER_HTTP" ;;
+  *kagentz.sysloggh.net*)
+    printf '%s' "$KAGENTZ_PUBLIC_CODE" ;;
 esac
 exit 0
 """
@@ -121,7 +123,8 @@ def _write_exec(path: pathlib.Path, body: str) -> None:
 
 
 def _run_monitor(tmp_path, *, tanko_svc="active", tanko_http="200",
-                 az_a2a_code="401", az_a2a_exit=0):
+                 az_a2a_code="401", az_a2a_exit=0,
+                 kagentz_public_code="302"):
     """Run the shipped monitor in a sandbox; return (proc, record_dir, log_path).
 
     Only the LOG constant is rewritten (to keep the run inside the worktree).
@@ -154,6 +157,7 @@ def _run_monitor(tmp_path, *, tanko_svc="active", tanko_http="200",
         "PI_HTTP": "200",
         "PI_BODY": CONNECTED_FIXTURE.read_text(),
         "SERVER_HTTP": "200",
+        "KAGENTZ_PUBLIC_CODE": kagentz_public_code,
     })
     proc = subprocess.run(["bash", str(script)], cwd=sandbox, env=env,
                           capture_output=True, text=True)
@@ -169,8 +173,9 @@ def test_healthy_run_is_quiet_and_never_reaches_mumuni(tmp_path):
     assert "Server: ✅ HTTP 200" in log
     assert "Abiba: ✅ Connected" in log
     assert "Tanko: ✅ service=active http=200" in log
-    assert "kagentz: ✅ A2A alive (HTTP 401)" in log
-    assert "Result: ✅ All healthy" in log
+    assert "kagentz C1: ✅ A2A alive (HTTP 401)" in log
+    assert "kagentz C3: ✅ public URL alive (HTTP 302)" in log
+    assert "Result: ✅ 0 issues (all healthy)" in log
 
     # A healthy run emits no notify at all — and certainly no Mumuni one.
     assert proc.stdout == ""
@@ -207,8 +212,8 @@ def test_failing_run_alerts_on_tanko_but_never_on_mumuni(tmp_path):
     # The rest of the monitor still ran alongside the failing Tanko leg.
     log = log_path.read_text()
     assert "Abiba: ✅ Connected" in log
-    assert "kagentz: ✅ A2A alive" in log
-    assert "Result: 🔴 1 issue(s) found" in log
+    assert "kagentz C1: ✅ A2A alive" in log
+    assert "Result: 🔴 INCIDENT — 1 issue(s) found" in log
 
 
 def test_unexpected_a2a_status_is_an_issue_not_healthy(tmp_path):
@@ -216,9 +221,9 @@ def test_unexpected_a2a_status_is_an_issue_not_healthy(tmp_path):
     assert proc.returncode == 0, proc.stderr
     log = log_path.read_text()
 
-    assert "kagentz: 🟡 A2A unexpected http=500 (running, warning)" in log
-    assert "kagentz: ✅ A2A alive" not in log
-    assert "Result: 🔴 1 issue(s) found" in log
+    assert "kagentz C1: 🟡 A2A unexpected http=500 (running, warning)" in log
+    assert "kagentz C1: ✅ A2A alive" not in log
+    assert "Result: 🔴 INCIDENT — 1 issue(s) found" in log
     assert "kagentz A2A server answered HTTP 500" in proc.stdout
 
 
@@ -230,10 +235,10 @@ def test_a2a_connection_failure_is_down_not_unexpected(tmp_path):
     assert proc.returncode == 0, proc.stderr
     log = log_path.read_text()
 
-    assert "kagentz: ❌ A2A down (HTTP 000)" in log
-    assert "kagentz: ✅ A2A alive" not in log
+    assert "kagentz C1: ❌ A2A down (HTTP 000)" in log
+    assert "kagentz C1: ✅ A2A alive" not in log
     assert "unexpected" not in log
-    assert "Result: 🔴 1 issue(s) found" in log
+    assert "Result: 🔴 INCIDENT — 1 issue(s) found" in log
     assert "kagentz A2A server DOWN (connection failed)" in proc.stdout
 
 

tests/test_zulip_kagentz_legs.py

@@ -30,8 +30,6 @@ import pathlib
 import stat
 import subprocess
 
-import pytest
-
 ROOT = pathlib.Path(__file__).resolve().parents[1]
 ZULIP_MONITOR = ROOT / "scripts" / "zulip-monitor.sh"
 CONNECTED_FIXTURE = ROOT / "tests" / "fixtures" / "zulip-health-connected.json"
@@ -209,25 +207,3 @@ def test_c1_000_is_incident(tmp_path):
     assert "all healthy" not in log
     # The notify fired for the A2A down.
     assert "kagentz A2A server DOWN" in proc.stdout
-
-
-# ── Prose assertions (kept as secondary, do not replace behavioural) ──
-
-def test_prose_c1_no_credential_needed():
-    """C1 header should say 'no credential needed'."""
-    prose = (ROOT / "zulip-health.prose.md").read_text()
-    assert "C1: A2A Server Health (no credential needed)" in prose
-
-
-def test_prose_c2_requires_litellm_key():
-    """C2 header should say 'requires LITELLM_KEY'."""
-    prose = (ROOT / "zulip-health.prose.md").read_text()
-    assert "C2: A2A Response Verification (requires LITELLM_KEY)" in prose
-
-
-def test_prose_c3_public_access_path():
-    """C3 section should exist and document 502/000 as incidents."""
-    prose = (ROOT / "zulip-health.prose.md").read_text()
-    assert "C3: Public Access Path" in prose
-    assert "https://kagentz.sysloggh.net/" in prose
-    assert "502" in prose