no-mistakes(review): Complete retired-alias field coverage; fix misleading example labels

tests/test_audit_hermes_config_alias.py

@@ -56,9 +56,9 @@ custom_providers:
 """
 
 
-def _run(tmp_path, alias):
-    cfg = tmp_path / f"{alias}.yaml"
-    cfg.write_text(BASE.format(alias=alias))
+def _run_config(tmp_path, name, text):
+    cfg = tmp_path / name
+    cfg.write_text(text)
     proc = subprocess.run(
         [sys.executable, str(AUDIT), str(cfg)],
         capture_output=True, text=True,
@@ -66,6 +66,10 @@ def _run(tmp_path, alias):
     return proc.returncode, proc.stdout
 
 
+def _run(tmp_path, alias):
+    return _run_config(tmp_path, f"{alias}.yaml", BASE.format(alias=alias))
+
+
 def test_live_canonical_alias_passes(tmp_path):
     """The RTX 5070 alias that actually resolves must satisfy Rule 8."""
     code, out = _run(tmp_path, "gpu-vision")
@@ -89,19 +93,53 @@ def test_retired_gemma_is_rejected(tmp_path):
     assert "RESULT: FAIL" in out
 
 
+def test_corrected_compression_example_passes(tmp_path):
+    """The corrected workaround (vision=gpu-vision, compression=syslog-auto) must PASS."""
+    code, out = _run(tmp_path, "gpu-vision")
+    assert code == 0, out
+    assert "[Rule 7] compression.model must be syslog-auto (got 'syslog-auto')" in out
+    assert "[Rule 7] auxiliary.compression.model must be syslog-auto (got 'syslog-auto')" in out
+    assert "RESULT: PASS" in out
+
+
 def test_retired_alias_in_delegation_is_rejected(tmp_path):
     """delegation.model has no dedicated value rule, so a retired name there used to PASS."""
-    cfg = tmp_path / "delegation-gpu-light.yaml"
-    cfg.write_text(
+    code, out = _run_config(
+        tmp_path,
+        "delegation-gpu-light.yaml",
         BASE.format(alias="gpu-vision").replace(
             "delegation:\n  provider: harness",
             "delegation:\n  provider: harness\n  model: gpu-light",
-        )
+        ),
     )
-    proc = subprocess.run(
-        [sys.executable, str(AUDIT), str(cfg)],
-        capture_output=True, text=True,
+    assert code == 1, out
+    assert "delegation.model = 'gpu-light' is retired" in out
+    assert "RESULT: FAIL" in out
+
+
+def test_retired_alias_in_custom_providers_is_rejected(tmp_path):
+    """custom_providers[*].model is model-bearing; a retired name there must fail."""
+    code, out = _run_config(
+        tmp_path,
+        "custom-provider-gpu-light.yaml",
+        BASE.format(alias="gpu-vision").replace(
+            "  - name: harness\n    key_env: LITELLM_API_KEY",
+            "  - name: harness\n    model: gpu-light\n    key_env: LITELLM_API_KEY",
+        ),
     )
-    assert proc.returncode == 1, proc.stdout
-    assert "delegation.model = 'gpu-light' is retired" in proc.stdout
-    assert "RESULT: FAIL" in proc.stdout
+    assert code == 1, out
+    assert "custom_providers[0].model = 'gpu-light'" in out
+    assert "RESULT: FAIL" in out
+
+
+def test_raw_alias_is_rejected(tmp_path):
+    """Raw-but-live model names must fail too, pointing at the stable alias."""
+    code, out = _run_config(
+        tmp_path,
+        "raw-qwen.yaml",
+        BASE.format(alias="gpu-vision").replace("default: syslog-auto", "default: qwen3.6-27B-code"),
+    )
+    assert code == 1, out
+    assert "model.default = 'qwen3.6-27B-code'" in out
+    assert "gpu-dense" in out
+    assert "RESULT: FAIL" in out