no-mistakes(review): Restore quiet-mode silence; keep provenance on failure alert

This commit is contained in:
2026-09-10 01:52:38 +00:00
parent 1974959cc9
commit bbdf6c1249
3 changed files with 48 additions and 29 deletions
+14 -3
View File
@@ -137,17 +137,28 @@ def test_json_reports_absolute_execution_provenance(ahc, monkeypatch, capsys):
def test_quiet_run_still_carries_provenance_on_the_alert_path(ahc, monkeypatch, capsys):
# The production cron runs --quiet; a report without provenance is
# unactionable (item 4). Both the header line and the ALERT line must carry it.
# The cron runs --quiet; a failure report must still carry provenance. The
# header line is suppressed in quiet mode, so the ALERT line is the carrier.
code, out = _run_main(ahc, monkeypatch, capsys, ["--quiet"])
assert code == 1
assert "📍 executed from: script=" in out
assert "📍 executed from:" not in out
alerts = [ln for ln in out.splitlines() if ln.startswith("ALERT agent-health:")]
assert alerts, out
assert f"script={os.path.abspath(str(AHC))}" in alerts[0]
assert f"cwd={os.getcwd()}" in alerts[0]
def test_quiet_healthy_run_emits_no_stdout(ahc, monkeypatch, capsys):
# --quiet is documented as "only output on failure": a run with no fleet
# failures must produce no stdout at all (the production cron runs --quiet).
for name in ("check_keys", "check_gpu_ports", "check_agents", "check_ct_liveness",
"check_config_integrity", "check_wrapper_integrity", "check_vault_secrets"):
monkeypatch.setattr(ahc, name, lambda: None)
code, out = _run_main(ahc, monkeypatch, capsys, ["--quiet"])
assert code == 0
assert out == ""
def test_json_surfaces_report_only_findings_separately(ahc, monkeypatch, capsys):
# Koby's down legs are reported but must not count as fleet failures; the
# --json payload exposes them in their own array (item 1 + f8).