SyslogSolution/prose-contracts
7
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add -f to curl to fail on HTTP >= 400
PR Pipeline — Authorize → Validate → Review → Merge / auth (pull_request) Successful in 3s
Details
PR Pipeline — Authorize → Validate → Review → Merge / validate (pull_request) Successful in 5s
Details
PR Pipeline — Authorize → Validate → Review → Merge / lint (pull_request) Successful in 3s
Details
PR Pipeline — Authorize → Validate → Review → Merge / ai-review (pull_request) Successful in 5s
Details
PR Pipeline — Authorize → Validate → Review → Merge / gate (pull_request) Successful in 0s
Details

Browse Source 
Without -f, a rejected credential (HTTP 401) returns curl exit 0, making
a failed alert indistinguishable from a successful one. With -f, curl
exits non-zero on HTTP >= 400, so DM_EXIT and STREAM_EXIT correctly
capture the transmission failure and the run log records it.
This commit is contained in:
root
2026-09-24 05:27:28 +00:00
parent 748ea389be
commit fda6c844ff
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/contract-run.sh
+2 -2
View File
@@ -104,7 +104,7 @@ else
if [ -n "$ZULIP_API_KEY" ] && command -v curl &> /dev/null; then if [ -n "$ZULIP_API_KEY" ] && command -v curl &> /dev/null; then
# DM to user 9 # DM to user 9
DM_EXIT=0 DM_EXIT=0
curl -s -X POST "${ZULIP_API_URL}/messages" \ curl -sf -X POST "${ZULIP_API_URL}/messages" \
-u "${ZULIP_USER}:${ZULIP_API_KEY}" \ -u "${ZULIP_USER}:${ZULIP_API_KEY}" \
-d "type=private" \ -d "type=private" \
-d "to=9" \ -d "to=9" \
@@ -112,7 +112,7 @@ else
# Stream agent-hub topic alerts-infra # Stream agent-hub topic alerts-infra
STREAM_EXIT=0 STREAM_EXIT=0
curl -s -X POST "${ZULIP_API_URL}/messages" \ curl -sf -X POST "${ZULIP_API_URL}/messages" \
-u "${ZULIP_USER}:${ZULIP_API_KEY}" \ -u "${ZULIP_USER}:${ZULIP_API_KEY}" \
-d "type=stream" \ -d "type=stream" \
-d "to=agent-hub" \ -d "to=agent-hub" \