4 Commits

Include renames

Author	SHA1	Message	Date
abiba-bot	194e256ac5	no-mistakes(review): Harden health-check provenance, infisical verification, report-only JSON, tests	2026-09-10 01:35:44 +00:00
abiba-bot	c66d9c1e20	fix: probe-drift round 2 — stale monitoring expectations (health check, PVE API, GPU port 80, report provenance) ... Second probe-drift correction pass after #65/#66/#68. All four legs were stale consumer expectations, not live faults. 1. scripts/agent-health-check.py (v4) - abiba declared pi-only runtime (harness purge): Hermes-era gateway, config and wrapper legs are skipped instead of failing. - koby declared report_only (captain ruling 2026-08-17, Rule 17): every koby leg is detected and reported, never counted as a fleet failure or repaired. - koby's CT 111 mapping corrected to storepve (.6); the old amdpve mapping made `pct status 111` fail and read as ct-unreachable. - wrapper check no longer FAILs .env-based wrappers that legitimately never invoke infisical (koonimo). - keys load in main() (load_agent_keys) so the module is importable/testable. - every run prints absolute execution provenance (script + cwd), in the header and in --json. Before: 6 FAILURE(S). After: 0 failures, koby reported read-only. 2. infrastructure-monitoring.prose.md - PVE API probe repointed from CT 116 (no pveproxy, 000) to the five real nodes on https://<node>:8006/api2/json/version, all 401 = alive. - any-HTTP-response liveness rule added (401/3xx alive; 000/timeout = DOWN). - LiteLLM health documented as 301 -> /litellm/health/liveliness, not bare 200. 3. gpu-monitor.prose.md - GPU health probes on :8080 (or router /health/unified); bare port 80 on a GPU host is forbidden (no listener -> false DEGRADED). - router /health/unified 301 -> /gpu/gpu-data documented as alive. - port-discipline + liveness rule + direct-fallback execution step. 4. Report provenance (all contracts) - docs/AUTHORING-GUIDE.md documents the rule; scripts/prose-lint.sh enforces that any **Report format** contract states an absolute path (pwd -P). - provenance added to gpu-monitor, infrastructure-monitoring, proxmox-monitor. Tests: tests/test_probe_drift.py (23 passed); prose-lint.sh clean + shellcheck clean; CI frontmatter validation passes. Evidence with per-leg before/after and absolute paths: docs/probe-drift-round2-evidence.md.	2026-09-10 01:23:54 +00:00
root	f57923b4fa	no-mistakes(document): test shellcheck hygiene; flagged monitor contract doc drift	2026-09-09 10:26:35 +00:00
root	7ed2e4e923	fix(zulip-monitor): Abiba leg reads nested zulip.connected; probe failures never restart ... The monitor's Abiba leg parsed the :9200/health payload at the top level (d.get('connected',False)) while the pi Zulip extension serves connection state NESTED at zulip.connected / zulip.last_error (verified against the extension's startHealthServer handler and the live endpoint). PI_CONNECTED was therefore always False and every run took the DISCONNECTED path, restarting a healthy bot: pm2 restarts=8 with the process created 2026-09-09T09:35:09Z, four ❌ Abiba verdicts today (04:23/05:35/06:55/09:35 UTC) and zero ✅, while the Zulip server answered HTTP 200 and the bot kept heartbeating. The watchdog was the fault, not the connection. Changes (Abiba leg only; every other leg byte-identical): - Read the real nested shape: zulip.connected, zulip.last_error and zulip.messages_processed. The old retry_count branch is DROPPED — the payload exposes no retry counter (the extension keeps retryCount internal and never serialises it), so the branch is fabricated and cannot stay. - Fail-safe restart decision: a fetch error (HTTP 000), non-2xx response, empty/unparseable body, or payload missing a boolean zulip.connected is a clearly-labelled PROBE FAILURE (🟠 alert + ⚠️ log line naming reason and HTTP code) and NEVER calls pm2 restart. pm2 restart runs only on affirmative zulip.connected=false (🔴/❌ path unchanged in wording). connected=true with last_error keeps the degraded 🟡 warn-no-restart path. Regression test (new tests/zulip-monitor-abiba.sh, 36 checks): extracts the real Abiba leg from between the # -- abiba-leg-start/-end markers in the shipped script and executes it verbatim with stubbed curl/notify/pm2 against fixtures of the real payload shape — asserts connected=true → no restart, connected=false → restart, and empty/garbage/missing-key/non-boolean/HTTP 000/HTTP 500 bodies → probe-failure alert with zero restarts. The suite fails loudly on the pre-fix base and on a marker-intact top-level-parse variant, so this class of bug cannot return silently.	2026-09-09 09:51:46 +00:00