2 Commits

Include renames

Author	SHA1	Message	Date
root	574cb99d76	feat: land the revision-preflight guard, fixed and wired into contract execution ... A contract verdict is only meaningful if it came from the merged copy. The fleet has been bitten three times on 2026-09-25 (a clone parked on a merged feature branch while executing from another clone; a script copied into the runner clone by hand; a stale local origin/master making an ancestry check report unlanded work). The control for this existed as an untracked draft and protected nobody, because it was entirely fail-open. Defect in the draft, preserved verbatim as tests/fixtures/revision-preflight.prefix.sh: git -C "$CLONE" show "origin/master:$(basename "$SCRIPT")" basename drops the scripts/ prefix, so for any script under scripts/ it queried the repo root, failed, took the "warn but don't block" branch and exited 0 - passing a script that exists in no revision at all. Reproduced: pre-fix + scripts/demo.sh under scripts/ -> 'could not resolve', EXIT=0 pre-fix + a script in no revision -> EXIT=0 Fixed guard (scripts/revision-preflight.sh): * resolves the repo-relative path inside the clone, so scripts/ paths resolve; * FAILS CLOSED - a path absent from the ref, an unresolvable ref, or a failed fetch is a failure, never a warning; * fetches the remote by default, because a stale local ref would otherwise pass a stale script as current; --no-fetch states the assumption instead of hiding it. Wiring (scripts/contract-run.sh): before executing, the wrapper runs the guard against the clone it lives in. Default CONTRACT_REVISION_PREFLIGHT=enforce withholds the verdict, alerts and exits 2 on mismatch; =warn logs and continues; =off skips. Verified live: match -> contract proceeds and PASSes; mismatch -> 'VERDICT WITHHELD', exit 2; =warn -> continues. Pinning (docs/contract-execution-pinning.md): every contract pins the clone contract-run.sh lives in - the deployed runner being /opt/contract-runner on CT 100. Documented that daily-health-digest has no contract file at all, which is why its execution copy was silently operator-chosen. Tests: tests/test_revision_preflight.sh, 15 assertions over a throwaway clone with a real bare remote. It runs the pre-fix draft against the same cases and shows it passing a ghost script, so the tests provably bite. shellcheck: scripts/revision-preflight.sh and the new test are clean. The three findings remaining in contract-run.sh (SC2086 x2, SC2034) are pre-existing and byte-identical on master.	2026-09-25 11:04:29 +00:00
root	7ed2e4e923	fix(zulip-monitor): Abiba leg reads nested zulip.connected; probe failures never restart ... The monitor's Abiba leg parsed the :9200/health payload at the top level (d.get('connected',False)) while the pi Zulip extension serves connection state NESTED at zulip.connected / zulip.last_error (verified against the extension's startHealthServer handler and the live endpoint). PI_CONNECTED was therefore always False and every run took the DISCONNECTED path, restarting a healthy bot: pm2 restarts=8 with the process created 2026-09-09T09:35:09Z, four ❌ Abiba verdicts today (04:23/05:35/06:55/09:35 UTC) and zero ✅, while the Zulip server answered HTTP 200 and the bot kept heartbeating. The watchdog was the fault, not the connection. Changes (Abiba leg only; every other leg byte-identical): - Read the real nested shape: zulip.connected, zulip.last_error and zulip.messages_processed. The old retry_count branch is DROPPED — the payload exposes no retry counter (the extension keeps retryCount internal and never serialises it), so the branch is fabricated and cannot stay. - Fail-safe restart decision: a fetch error (HTTP 000), non-2xx response, empty/unparseable body, or payload missing a boolean zulip.connected is a clearly-labelled PROBE FAILURE (🟠 alert + ⚠️ log line naming reason and HTTP code) and NEVER calls pm2 restart. pm2 restart runs only on affirmative zulip.connected=false (🔴/❌ path unchanged in wording). connected=true with last_error keeps the degraded 🟡 warn-no-restart path. Regression test (new tests/zulip-monitor-abiba.sh, 36 checks): extracts the real Abiba leg from between the # -- abiba-leg-start/-end markers in the shipped script and executes it verbatim with stubbed curl/notify/pm2 against fixtures of the real payload shape — asserts connected=true → no restart, connected=false → restart, and empty/garbage/missing-key/non-boolean/HTTP 000/HTTP 500 bodies → probe-failure alert with zero restarts. The suite fails loudly on the pre-fix base and on a marker-intact top-level-parse variant, so this class of bug cannot return silently.	2026-09-09 09:51:46 +00:00