fix(alignment): resolve /root/ hardcoding and stale tanko-DSH references #147

Merged

abiba-bot merged 7 commits from fix/agent-health-root-hardcoding-20260928 into master 2026-09-28 23:05:31 +00:00

Conversation 0 Commits 7 Files Changed 5

+55 -22

abiba-bot commented 2026-09-28 20:50:04 +00:00

Owner

Copy Link

Copy Source

Summary

Two fixes from the verify lane retro review, independently confirmed by firstmate.

F1 — THE FALSE POSITIVE

agent-health-check.py hardcoded /root/ when looking for the Hermes CLI wrapper, so it reported wrapper-missing:tanko for an agent that has a perfectly good wrapper at /home/jerome/.local/bin/hermes.

Fix: Added get_user_home(user) helper that resolves the home directory from the agent user field. Used in every leg that touches a user home (wrapper, hermes-real, .env, config.yaml).

Proof: Old code reported wrapper-missing:tanko. New code reports tanko healthy.

F2 — STALE REFERENCES

tanko is HYBRID (DSH + Hermes) since 2026-08-27, but four files still said otherwise:

• hermes-zulip-restore.prose.md (3 lines)
• hermes-zulip-plugin.prose.md (3 lines)
• infrastructure-control.prose.md (1 line)
• docs/probe-drift-round2-evidence.md (6 lines)

Fix: Updated each to describe tanko as hybrid. For the evidence doc, added a historical note explaining that the DSH-only observations reflected the /root/ hardcoding bug, not the underlying truth — a silently-updated evidence doc is worse than a stale one.

Out of scope

• tanko runtime value unchanged (hybrid is correct)
• nothing installed on tanko
• koby hosts read-only

## Summary Two fixes from the verify lane retro review, independently confirmed by firstmate. ### F1 — THE FALSE POSITIVE agent-health-check.py hardcoded /root/ when looking for the Hermes CLI wrapper, so it reported wrapper-missing:tanko for an agent that has a perfectly good wrapper at /home/jerome/.local/bin/hermes. **Fix:** Added get_user_home(user) helper that resolves the home directory from the agent user field. Used in every leg that touches a user home (wrapper, hermes-real, .env, config.yaml). **Proof:** Old code reported wrapper-missing:tanko. New code reports tanko healthy. ### F2 — STALE REFERENCES tanko is HYBRID (DSH + Hermes) since 2026-08-27, but four files still said otherwise: - hermes-zulip-restore.prose.md (3 lines) - hermes-zulip-plugin.prose.md (3 lines) - infrastructure-control.prose.md (1 line) - docs/probe-drift-round2-evidence.md (6 lines) **Fix:** Updated each to describe tanko as hybrid. For the evidence doc, added a historical note explaining that the DSH-only observations reflected the /root/ hardcoding bug, not the underlying truth — a silently-updated evidence doc is worse than a stale one. ## Out of scope - tanko runtime value unchanged (hybrid is correct) - nothing installed on tanko - koby hosts read-only

abiba-bot added 4 commits 2026-09-28 20:50:05 +00:00

Merge PR #144: fix(alignment): use llmuser with sudo for swap-gpu-dense-model.sh 4c715526ef

Merge PR #145: fix(alignment): clarify tanko live LiteLLM proxy status in health-check description c6fd8eece3

Merge PR #146: fix(alignment): recognize tanko as hybrid (DSH + Hermes) in agent-health-check 2ea6b4fc17

fix(alignment): resolve /root/ hardcoding and stale tanko-DSH references ... 2238777a2f

F1: agent-health-check.py now resolves the home directory from the agent's
user field via a shared helper (get_user_home) instead of hardcoding /root/.
This fixes the false-positive wrapper-missing:tanko report — tanko has a
working wrapper at /home/jerome/.local/bin/hermes, but the check was looking
in /root/.local/bin/.

F2: Updated stale references that described tanko as DSH-only:
- hermes-zulip-restore.prose.md: tanko excluded — hybrid (DSH + Hermes)
- hermes-zulip-plugin.prose.md: tanko excluded — hybrid (DSH + Hermes)
- infrastructure-control.prose.md: tanko is hybrid (DSH + Hermes) agent
- docs/probe-drift-round2-evidence.md: marked as historical record with
  dated note explaining that the DSH-only observations reflected the
  /root/ hardcoding bug, not the underlying truth

Refs: fix/agent-health-root-hardcoding-20260928

abiba-bot added 1 commit 2026-09-28 21:21:01 +00:00

fix(alignment): repair f-string quoting in config check, add home to scope ... 97dc2d772f

- Fixed line 537: f-string now uses single quotes inside double-quoted shell
  command to avoid nested quote collision
- Added home = get_user_home(user) to check_config_integrity loop scope so
  the config check can resolve the correct home directory

abiba-bot added 1 commit 2026-09-28 22:25:35 +00:00

fix(alignment): accept multiple wrapper shapes in hermes-real check ... af9397d672

The fleet's wrappers do not all use a hermes-real indirection. Some (tanko,
mumuni) exec the venv module directly. This check now:
  1. Tries hermes-real at {home}/.local/bin (koonimo's shape)
  2. Tries the venv under {home}/.hermes/hermes-agent/venv (tanko/mumuni shape)
  3. Tries /usr/local/lib/hermes-agent/venv (legacy system-wide shape)

Each match is reported with which shape it matched, so a genuinely broken
wrapper is still a failure while a different-but-valid shape is not.

abiba-bot added 1 commit 2026-09-28 23:03:56 +00:00

Merge branch 'master' into fix/agent-health-root-hardcoding-20260928 3b74ca28d1

abiba-bot merged commit 4320369bb9 into master 2026-09-28 23:05:31 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

abiba-bot jerome (Jerome Kwame Tabiri) kagentz-bot kwame (Kwame Tabiri) mumuni-bot (Mumuni 🦅 (Syslog Falcon)) tanko-bot theo

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SyslogSolution/prose-contracts#147