SyslogSolution/prose-contracts
7
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: prose-lint allowlist for synthetic credential example #150

Merged
abiba-bot merged 1 commits from fix/prose-lint-allowlist-20261003 into master 2026-10-03 10:07:32 +00:00
Conversation 0 Commits 1 Files Changed 1
+1 -1
abiba-bot commented 2026-10-03 09:36:39 +00:00
Owner
Copy Link
Copy Source

Fixes prose-lint failure on master caused by synthetic credential example in hermes-key-enforcement.prose.md. Changed allowlist rule from openai-key to * to match both openai-key and secret-assign rules. Chose option (b) (allowlist) because existing entry already documented the synthetic example. Verification: bash scripts/prose-lint.sh now exits 0. Corr=7c202734ec6c452a

Fixes prose-lint failure on master caused by synthetic credential example in hermes-key-enforcement.prose.md. Changed allowlist rule from openai-key to * to match both openai-key and secret-assign rules. Chose option (b) (allowlist) because existing entry already documented the synthetic example. Verification: bash scripts/prose-lint.sh now exits 0. Corr=7c202734ec6c452a
abiba-bot added 1 commit 2026-10-03 09:36:39 +00:00
fix: prose-lint allowlist for synthetic credential example
PR Pipeline — Authorize → Validate → Review → Merge / auth (pull_request) Successful in 13s
Details
PR Pipeline — Authorize → Validate → Review → Merge / validate (pull_request) Successful in 5s
Details
PR Pipeline — Authorize → Validate → Review → Merge / lint (pull_request) Successful in 23s
Details
PR Pipeline — Authorize → Validate → Review → Merge / ai-review (pull_request) Successful in 11s
Details
PR Pipeline — Authorize → Validate → Review → Merge / gate (pull_request) Successful in 1s
Details
3fe5cc3af1 
The synthetic example 'sk-synthetic-litellm-' in hermes-key-enforcement.prose.md:217
was flagged by the secret-assign rule as a credential-shaped assignment. The
existing allowlist entry only covered openai-key, so secret-assign still failed.

Fix: Change the rule from openai-key to * (matches any rule) and update the
reason to explain why (2026-10-03: secret-assign also matches the credential-shaped
assignment).

This restores prose-lint on master, which was RED and blocking every open PR's
lint job (including PR #149's lint job 2160).

Chose option (b) (allowlist) over option (a) (restructure) because:
- The existing entry already documented the synthetic example
- Changing the rule to * is the minimal, honest fix
- Restructuring the command would risk weakening the enforcement check

Correlation: corr=7c202734ec6c452a
abiba-bot merged commit 1f02b00aaa into master 2026-10-03 10:07:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
abiba-bot jerome (Jerome Kwame Tabiri) kagentz-bot kwame (Kwame Tabiri) mumuni-bot (Mumuni 🦅 (Syslog Falcon)) tanko-bot theo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SyslogSolution/prose-contracts#150