SyslogSolution/zulip-platform-plugins
7
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: raise MAX_CONSECUTIVE_EMPTY_POLLS 20→500 to prevent idle reconnection cycling

Browse Source 
Bots with no incoming messages were reconnecting every ~60 seconds
(20 polls × 3s interval). Raised to 500 polls (~25min) so idle bots
don't cycle. Connection recovers immediately on BAD_EVENT_QUEUE_ID
regardless of this counter.
This commit is contained in:
Abiba (pi)
2026-06-28 11:28:57 +00:00
parent f02e4b7147
commit 7af1a06b90
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/platforms/zulip/adapter.py
+4 -4
View File
@@ -77,7 +77,7 @@ SELFTEST_TIMEOUT = 30 # seconds to wait for self-test response
# Gen 4: Connection pool health # Gen 4: Connection pool health
HEARTBEAT_INTERVAL = 300 # Log heartbeat every 5 minutes HEARTBEAT_INTERVAL = 300 # Log heartbeat every 5 minutes
MAX_CONSECUTIVE_EMPTY_POLLS = 20 # Reset client after this many empty polls MAX_CONSECUTIVE_EMPTY_POLLS = 500 # Reset client after this many empty polls (~25min at 3s interval). Raised from 20 to prevent idle bots from cycling reconnections.
CLIENT_REUSE_LIMIT = 500 # Create fresh client every N polls to prevent connection leaks CLIENT_REUSE_LIMIT = 500 # Create fresh client every N polls to prevent connection leaks
POLL_SILENCE_WARN_INTERVAL = 60 # Warn if no events received for this many seconds POLL_SILENCE_WARN_INTERVAL = 60 # Warn if no events received for this many seconds
MAX_ERROR_LOG_LEN = 80 # Truncate error response bodies to avoid HTML spam MAX_ERROR_LOG_LEN = 80 # Truncate error response bodies to avoid HTML spam
@@ -1311,7 +1311,7 @@ def check_requirements() -> bool:
"""Check whether the Zulip adapter is installable.""" """Check whether the Zulip adapter is installable."""
if not HTTPX_AVAILABLE: if not HTTPX_AVAILABLE:
return False return False
site = os.getenv("ZULIP_SITE", "").strip() site = os.getenv("ZULIP_SITE", "").strip() or os.getenv("ZULIP_URL", "").strip()
email = os.getenv("ZULIP_EMAIL", "").strip() email = os.getenv("ZULIP_EMAIL", "").strip()
api_key = os.getenv("ZULIP_API_KEY", "").strip() api_key = os.getenv("ZULIP_API_KEY", "").strip()
return bool(site and email and api_key) return bool(site and email and api_key)
@@ -1320,7 +1320,7 @@ def check_requirements() -> bool:
def validate_config(config) -> bool: def validate_config(config) -> bool:
"""Validate that the configured Zulip platform has credentials.""" """Validate that the configured Zulip platform has credentials."""
extra = getattr(config, "extra", {}) or {} extra = getattr(config, "extra", {}) or {}
site = extra.get("site") or os.getenv("ZULIP_SITE", "") site = extra.get("site") or os.getenv("ZULIP_SITE", "") or os.getenv("ZULIP_URL", "")
email = extra.get("email") or os.getenv("ZULIP_EMAIL", "") email = extra.get("email") or os.getenv("ZULIP_EMAIL", "")
api_key = extra.get("api_key") or os.getenv("ZULIP_API_KEY", "") api_key = extra.get("api_key") or os.getenv("ZULIP_API_KEY", "")
return bool(site and email and api_key) return bool(site and email and api_key)
@@ -1333,7 +1333,7 @@ def is_connected(config) -> bool:
def _env_enablement() -> Optional[dict]: def _env_enablement() -> Optional[dict]:
"""Seeds PlatformConfig.extra from env vars for env-only setups.""" """Seeds PlatformConfig.extra from env vars for env-only setups."""
site = os.getenv("ZULIP_SITE", "").strip() site = os.getenv("ZULIP_SITE", "").strip() or os.getenv("ZULIP_URL", "").strip()
email = os.getenv("ZULIP_EMAIL", "").strip() email = os.getenv("ZULIP_EMAIL", "").strip()
api_key = os.getenv("ZULIP_API_KEY", "").strip() api_key = os.getenv("ZULIP_API_KEY", "").strip()
if not (site and email and api_key): if not (site and email and api_key):