Sprint A Wahab review batch — categories, property hierarchy, priority grouping #4

2026-08-02T13:36:20Z

abiba-bot commented

2026-08-02 13:36:20 +00:00

Implements Wahab feedback Sprint A (report sections 3.1-3.5, 3.9, 3.11):

Categories — Gas Leak hidden from form (show_in_form=False) but keeps urgent SLA; new Aluminum/Glass, Carpentry, Mould & Damp Maintenance categories; Lost Property → Missing Item rename with startup self-heal guard for legacy DBs.
Property picker — 3-level Property → Building → Apartment cascade with searchable combobox.
Priority grouping — group-by-priority on tickets list + dashboard with age sorting.
Sticky-priority fix (clear on mode switch) and Mould & Damp auto-default reset on category change.

Validated through the no-mistakes pipeline: review low-risk, 16/16 tests pass, docs synced, lint-clean (changed files only). Note: no-mistakes could not create this PR itself (Gitea provider unsupported) — pushed the branch and opened here.

Implements Wahab feedback Sprint A (report sections 3.1-3.5, 3.9, 3.11): 1. **Categories** — Gas Leak hidden from form (show_in_form=False) but keeps urgent SLA; new Aluminum/Glass, Carpentry, Mould & Damp Maintenance categories; Lost Property → Missing Item rename with startup self-heal guard for legacy DBs. 2. **Property picker** — 3-level Property → Building → Apartment cascade with searchable combobox. 3. **Priority grouping** — group-by-priority on tickets list + dashboard with age sorting. 4. Sticky-priority fix (clear on mode switch) and Mould & Damp auto-default reset on category change. Validated through the no-mistakes pipeline: review low-risk, 16/16 tests pass, docs synced, lint-clean (changed files only). Note: no-mistakes could not create this PR itself (Gitea provider unsupported) — pushed the branch and opened here.

abiba-bot added 5 commits 2026-08-02 13:36:20 +00:00

feat: Sprint A Wahab review batch — categories, property hierarchy, priority grouping 2407f294f4

Items 1-5, 9, 11 from denya-wahab-feedback-s2:
- Category.show_in_form (alert-only flag): Gas Leak hidden from issue picker
  but kept urgent for SLA/alert and reporting; emergency quick path on the
  new-issue form creates urgent tickets via include_hidden categories.
- Seed: Aluminum/Glass, Carpentry, Mould & Damp (Medium default) maintenance
  categories; Lost Property renamed Missing Item (+ sub).
- One alembic migration: add show_in_form (backfill True, Gas Leak False) +
  data rename Lost Property -> Missing Item.
- Property -> Building -> Apartment cascade with searchable apartment combobox
  on the new-issue form and ticket list filters; /api/tickets/units gains
  building filter + /units/grouped variant; /api/tickets gains additive
  building/unit_id filters. apartment_mapping.json committed (deterministic).
- Group-by-priority toggle on /tickets (four sections + unknown bucket,
  age-sortable, composes with filters, URL deep links), FM dashboard active
  tickets, and CS dashboard priority card click-through.
- Tests: 13 new (category visibility, seed idempotency/sync, unit grouping,
  ticket building/unit filters).

no-mistakes(review): Fix stale urgent priority when leaving emergency mode ae17005932

no-mistakes(review): Add startup self-heal guard for show_in_form column db6826cb49

no-mistakes(review): Extend legacy self-heal rename; clear stale Mould & Damp priority default 663354eeaf

no-mistakes(document): Sync AGENTS.md taxonomy, drop unused imports 5e9ec29439

abiba-bot merged commit ffed595dbd into main

2026-08-02 13:36:31 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SyslogSolution/denya-onecare#4