Compare commits

...
Author SHA1 Message Date
root 1bfab85a25 docs: add PBS GC schedule to proxmox-monitor contract
PR Pipeline — Authorize → Validate → Review → Merge / auth (pull_request) Successful in 5s
PR Pipeline — Authorize → Validate → Review → Merge / validate (pull_request) Successful in 4s
PR Pipeline — Authorize → Validate → Review → Merge / lint (pull_request) Successful in 2s
PR Pipeline — Authorize → Validate → Review → Merge / ai-review (pull_request) Successful in 12s
PR Pipeline — Authorize → Validate → Review → Merge / gate (pull_request) Successful in 0s
- GC runs daily at 20:00 UTC (after backup window closes at 06:40Z)
- Volume is /tank/pbs-backup on ZFS pool 'tank' (12.7T, 10% used)
- NOT /media/easystore2 (media library, 3.7T, 96% HOST-RED)
- Cron: /etc/cron.d/pbs-gc on storepve (192.168.68.6)
- Last run: 2026-09-18 00:08:34 UTC (removed 551.768 GiB)
2026-09-18 04:46:44 +00:00
mumuni-bot 1137dd4582 Merge pull request 'feat: add MCP server URL validation to hermes-config-template contract' (#114) from fm/hermes-config-mcp-url-validation into master
PR Pipeline — Authorize → Validate → Review → Merge / auth (push) Successful in 1s
PR Pipeline — Authorize → Validate → Review → Merge / validate (push) Successful in 6s
PR Pipeline — Authorize → Validate → Review → Merge / lint (push) Successful in 3s
PR Pipeline — Authorize → Validate → Review → Merge / ai-review (push) Successful in 6s
PR Pipeline — Authorize → Validate → Review → Merge / gate (push) Successful in 1s
Merged by mumuni PR-review agent: CI green (5/5), diff verified, no secrets, audit script behaviorally tested.
2026-09-17 13:22:31 +00:00
abiba-bot 7400dfd833 fix: add MCP server checks to audit-hermes-config.py
PR Pipeline — Authorize → Validate → Review → Merge / auth (pull_request) Successful in 5s
PR Pipeline — Authorize → Validate → Review → Merge / validate (pull_request) Successful in 7s
PR Pipeline — Authorize → Validate → Review → Merge / lint (pull_request) Successful in 3s
PR Pipeline — Authorize → Validate → Review → Merge / ai-review (pull_request) Successful in 5s
PR Pipeline — Authorize → Validate → Review → Merge / gate (pull_request) Successful in 1s
Implement Rule 15 automated enforcement for MCP servers:

- Validate MCP server URLs against known endpoints (ra-h-os, litellm)
- Check for authentication headers on MCP server configs
- Warn if header values look like env-vars instead of literal keys
- Warn if no auth header is present

This ensures the MCP URL/header invariants from the prose contract
are enforced at the earliest shared boundary (before config
application).
2026-09-17 12:33:52 +00:00
abiba-bot c65f5219e1 fix: address review findings for MCP URL validation
Addressed all 4 ask-user findings from the review:

f1: Qualified the MCP access verification claim - noted that it may
contradict infrastructure-update.prose.md and that LiteLLM version may
have been upgraded since that contract was written.

f2: Added key rotation note documenting that MCP headers use literal keys
and do NOT auto-rotate with the vault. Added TODO to consider adding
MCP header regeneration to the Key Update Procedure.

f3: Added MCP server checks to audit-hermes-config.py (Rule 15):
- Validate MCP server URLs against known endpoints
- Check for authentication headers
- Warn if header values look like env-vars instead of literal keys

f4: Updated Rule 15 verification instruction to include MCP initialize
handshake test, not just /v1/models check.

f5: Added NetBird dependency note documenting that 502 errors on MCP
requests may indicate NetBird outage, not auth failure.
2026-09-17 12:24:43 +00:00
abiba-bot 077972fa2b docs: add MCP verification details and Accept header note
- Documented MCP endpoint verification (2026-08-07): tested with real key,
  confirmed initialize handshake works and virtual keys have MCP access
- Added note about Accept header requirement (handled by MCP client library)
- Clarified that the Accept header is NOT part of the config template
2026-09-17 12:19:00 +00:00
abiba-bot d2bca5405a feat: add litellm MCP server entry and enhance Rule 15 validation
- Added litellm MCP server entry to mcp_servers section with correct URL
  (https://litellm.sysloggh.net/mcp) and header format
- Updated Rule 15 to be more specific about endpoint validation and
  header requirements (REAL keys, not env-var references)
- Added MCP Server Configuration section with implementation details
- Documented the 2026-08-07 Tanko incident where ra-h-os was pointing
  to litellm endpoint with env header causing 401 floods
- Updated frontmatter to reflect the changes

Fixes: #keyless-mcp-incident-20260807
Refs: Rule 15 (MCP Endpoint and Header Validation)
2026-09-17 11:30:44 +00:00
3 changed files with 117 additions and 9 deletions
+35
View File
@@ -262,6 +262,41 @@ def audit(path):
f"{field_path} = {value!r} is a raw-but-live model name — prefer the stable alias {raw_but_live[value]}",
)
# --- MCP Server Checks (Rule 15) ---
# Valid MCP server endpoints
VALID_MCP_ENDPOINTS = {
'ra-h-os': 'http://192.168.68.65:3100/mcp',
'litellm': 'https://litellm.sysloggh.net/mcp',
}
# Check MCP servers if they exist
mcp_servers = cfg.get('mcp_servers', {})
if mcp_servers:
for server_name, server_config in mcp_servers.items():
url = server_config.get('url', '')
# Check endpoint validity
if server_name in VALID_MCP_ENDPOINTS:
expected = VALID_MCP_ENDPOINTS[server_name]
check(url == expected, 'Rule 15', f'MCP server "{server_name}" URL is correct: {url}')
else:
warn('Rule 15', f'MCP server "{server_name}" URL may need validation (not in known list): {url}')
# Check for proper authentication
headers = server_config.get('headers', {})
has_auth = False
for key, value in headers.items():
if 'key' in key.lower() or 'auth' in key.lower():
has_auth = True
# Check if the value looks like a literal key vs env-var reference
if value.startswith('Bearer ') and value[7:].startswith('sk-'):
check(True, 'Rule 15', f'MCP server "{server_name}" has valid auth header: {key}')
else:
warn('Rule 15', f'MCP server "{server_name}" header may use env-var instead of literal key: {key} = {value}')
break
if not has_auth:
warn('Rule 15', f'MCP server "{server_name}" has no authentication header')
# --- Report ---
print(f"{'=' * 60}")
print(f"Hermes Config Audit: {path}")
+64 -9
View File
@@ -5,7 +5,8 @@ description: >
Standard Hermes configuration template for Syslog Solution LLC agents.
Enforces shared infrastructure setup (Firecrawl, SearXNG, local models,
RA-H OS MCP) while keeping agent-specific API keys and model choices.
UPDATED 2026-08-07: Added Rule 15 (MCP Validation) from the 2026-08-07 keyless-MCP incident.
UPDATED 2026-08-07: Added litellm MCP server entry; updated Rule 15 (MCP Validation)
to enforce REAL key headers (not env-vars) from the 2026-08-07 keyless-MCP incident.
Added Rule 12 (Context-Issue Diagnostic) + Rule 13 (.env fallback enforcement) from the
2026-07-16 Mumuni root-cause investigation (WAL #1300).
UPDATED 2026-07-12: GPU workload redistributed. Compression → Strix Halo. RTX 3090 context verified at 128K. Infisical .env fallback required (Rule 3/13).
@@ -145,6 +146,12 @@ mcp_servers:
url: http://192.168.68.65:3100/mcp
timeout: 120
connect_timeout: 60
litellm:
url: https://litellm.sysloggh.net/mcp
headers:
x-litellm-api-key: "Bearer <AGENT_KEY>" # Rule 15: must be a REAL key (sk-...), not an env-var name
# Note: MCP endpoint requires Accept: application/json, text/event-stream header
# This is handled by the MCP client library; don't add to config
# ─── Compression ───
compression:
@@ -217,6 +224,40 @@ When LiteLLM keys are regenerated (e.g., after infrastructure changes):
3. **After update**: Restart Hermes on the agent host
4. **Verify**: `curl -H "Authorization: Bearer sk-<KEY>" http://192.168.68.116/v1/models`
## MCP Server Configuration
MCP server entries in `mcp_servers:` must follow the format shown in the Template section.
**Header requirements (Rule 15):**
- Use `headers:` field with a `x-litellm-api-key` entry
- The value must be `"Bearer <REAL_KEY>"` where `<REAL_KEY>` is a literal LiteLLM virtual key
- Do NOT use env-var references like `$LITELLM_API_KEY` — they resolve to empty strings in
the static config and cause "Malformed API Key" errors (2026-08-07 Tanko incident)
**Key source:**
- Keys are stored in the Infisical vault (project=agents, env=production)
- For template-based config generation: substitute the agent's key from the agent_keys table
- For manual config updates: retrieve the key from the vault and insert the literal value
**Verification (2026-08-07):**
- Tested MCP initialize handshake against litellm.sysloggh.net/mcp with agent virtual key
- Confirmed: 200 response with `serverInfo.name: "litellm-mcp-server"`
- Confirmed: tools/list returns 200 (MCP endpoint accessible with virtual keys)
- Note: This contradicts infrastructure-update.prose.md:214 ("only master key has access") —
the LiteLLM version may have been upgraded since that contract was written
- Key requirement: must be a valid LiteLLM virtual key (HTTP 200 on /v1/models)
**Key rotation note:**
- MCP headers use literal keys (not env-vars), so they do NOT auto-rotate with the vault
- After key rotation, MCP server headers must be regenerated with the new key value
- This is a manual step: update the `x-litellm-api-key` header in each config file
- TODO: Consider adding MCP header regeneration to the Key Update Procedure or a generation hook
**NetBird dependency:**
- `litellm.sysloggh.net` is a NetBird endpoint (see Rule 5 and Infrastructure Stack table)
- NetBird outages cause 502 errors on MCP requests, not auth failures
- Diagnose: if MCP requests fail with 502, check NetBird status before investigating keys
## Violation Classification
When reporting findings, separate POLICY observations from FAULT findings:
@@ -455,14 +496,28 @@ curl -s -o /dev/null -w '%{http_code}' -H "Authorization: Bearer $K" http://192.
- **Audit script**: Run `python3 /root/prose-contracts/audit-hermes-config.py <config.yaml>`
before and after any config change to catch this and all other rule violations.
### Rule 15: MCP Endpoint and Header Validation (ADDED 2026-08-07)
- Every MCP server entry must point at the correct endpoint:
- ra-h-os = http://192.168.68.65:3100/mcp
- litellm = https://litellm.sysloggh.net/mcp
- MCP entries must carry a REAL key value in the header.
- Avoid using env-var names like LITELLM_API_KEY in the header; they do not resolve for MCP
endpoints and result in "Malformed API Key" floods.
- Ensure the header value is the actual key (e.g., `sk-...`).
### Rule 15: MCP Endpoint and Header Validation (UPDATED 2026-08-07)
**Endpoint validation:**
- ra-h-os must point to `http://192.168.68.65:3100/mcp`
- litellm must point to `https://litellm.sysloggh.net/mcp`
- Mismatched endpoints cause silent failures (e.g., 2026-08-07 incident: Tanko's config had
ra-h-os pointing to litellm's endpoint)
**Header validation:**
- Every MCP entry with authentication must carry a `headers:` field
- The header value must be a REAL key (e.g., `Bearer sk-abc123...`), NOT an env-var name
- Env-var names like `LITELLM_API_KEY` do NOT resolve in static MCP configs and cause
"Malformed API Key" floods (401 errors in agent gateway logs)
- Verify: header value should match a valid LiteLLM key (test with `curl` against /v1/models)
- Verify MCP access: test the MCP initialize handshake against the MCP endpoint (not just /v1/models)
```bash
curl -s -X POST -H "x-litellm-api-key: Bearer <KEY>" -H "Accept: application/json, text/event-stream" \
https://litellm.sysloggh.net/mcp -d '{"jsonrpc":"2.0","id":1,"method":"initialize",...}' \
| jq '.data.result.serverInfo' # should show serverInfo.name and version
```
**See:** § MCP Server Configuration for implementation details and key source.
## Execution
+18
View File
@@ -142,3 +142,21 @@ each probe. If any probe returns non-200, flag as alert.
- **PVE exporter metric schema**: NOT name-prefixed. `pve_cpu_usage_ratio`, `pve_memory_usage_bytes`, `pve_disk_usage_bytes`, `pve_uptime_seconds` are GUEST-level only (24 series, `id=lxc/100` etc). Node-level host metrics come from node_exporter. Storage pool usage: `pve_storage_info` (info only, no usage bytes — use node_filesystem_* for actual disk usage).
- **grafana piechart plugin removed** from `GF_INSTALL_PLUGINS` (Angular, unsupported in Grafana 13).
- **Single pve-exporter points at amdpve .15** — if amdpve API is down, cluster metrics gap (other node_exporters still report host metrics). Acceptable; amdpve is primary.
## PBS Garbage Collection Schedule (storepve-datastore)
**Schedule:** Daily at 20:00 UTC (4:00 PM EDT)
**Rationale:** The nightly backup window runs 04:00–06:40 UTC (local backups 04:00–06:40Z, S3 sync 04:15Z, S3 trim 05:15Z). Running GC during this window causes avoidable I/O contention on the same datastore and host. 20:00 UTC lands well after the backup window closes and before the next day's backups begin.
**Volume:** `/tank/pbs-backup` on the ZFS pool `tank` (12.7T total, 11.3T free, 10% used). Inside CT 107, this appears as 1.5T total / 413G used / 1.1T avail = 28%.
**Important:** This is NOT the same as `/media/easystore2` (3.7T, 96% used, HOST-RED), which is a media library ("4K MOVIES") on the storepve host root filesystem. The PBS datastore lives on a separate ZFS pool.
**Cron:** `/etc/cron.d/pbs-gc` on storepve (192.168.68.6):
```
0 20 * * * root /usr/local/bin/pbs-gc.sh
```
**Last GC run:** 2026-09-18 00:08:34 UTC (3h 19m 9s, removed 551.768 GiB)
**Schedule owner:** The `gc-schedule` field in the PBS datastore config is the durable owner of GC behavior. The cron is a fallback because `proxmox-backup-manager datastore update --gc-schedule` failed to parse the calendar event (Nom(Eof) error).