security(secrets): remove committed credentials from the tree and read them from the vault/environment #112
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: SyslogSolution/prose-contracts#112
Reference in New Issue
Block a user
Four live credentials were committed in this repository. This removes them from the working tree and replaces them with vault references. Removal does not un-expose them - they remain in the repository history - so rotation is a separate decision, raised with the captain.
What was exposed (each verified by firstmate at the authority, not inferred)
admin/<password>infrastructure-control.prose.md:184"role":"ROLE_ADMIN"infrastructure-control.prose.md:185,stirling-pdf-agent-access.prose.md(2x)agent-zero-fix-summary.md:20,51,agent-zero-openrouter-key.prose.md:93GET /api/v1/key: 200, usage $3.89, no spend limitscripts/zulip-monitor.sh:12,44,scripts/daily-infra-report.py:25GET /api/v1/users/me: 200, and it is the same key the running bot usesThe live one was new to us today: the chat health check stopped authenticating, and chasing that led to the literal in the script - and then to the rest.
Changes (11 files)
ZULIP_API_KEY="${ZULIP_API_KEY:?ZULIP_API_KEY not set - refusing to run with no credential}"and the Python equivalent raisingSystemExit. A script that silently runs unauthenticated is how this class hides.«vault: infrastructure/production STIRLING_ADMIN_PASSWORD»,«vault: agents/production OPENROUTER_API_KEY». No prefixes, no hints, no "redacted" wrappers containing the value - the OpenRouter key was previously inside exactly such a wrapper.Audit (whole repository, documents included)
Before -> after, per pattern: the specific exposed literals 7 -> 0 (across all four);
sk-or-v1-3 -> 0;sk-(20+ chars) -> 0 real hits;Bearer <token>-> 0;PASSWORD=/SECRET=/X-API-Key:-> 0; credential-in-prose patterns (credentials?:,API key:+ value,admin+ value) -> 0 real hits, with the remaining matches listed as non-credential references.The first pass of this audit reported "nothing else found" while the same Zulip key sat three lines below the line it had just edited, and it missed the credential-in-prose shapes that hid the Stirling password - both were caught by re-running it properly, which is why the raw output is quoted rather than a conclusion.
Not in this change
Reviewers: (1) confirm each of the four values is genuinely absent from the tree on this branch (grep for all four, paste the zeros) and that no prefix or hint of any remains; (2) confirm every replacement is a vault reference rather than a paraphrase; (3) scrutinise
litellm-api-keys.prose.md, which loses the most lines - confirm the deletions are credential text and not substance; (4) run the two changed scripts with the environment variable set and unset - the success and the loud refusal both matter; (5) confirm no new credential was introduced anywhere in the diff. Do NOT merge.Scripts that had hardcoded credentials: - scripts/zulip-monitor.sh:12 (was ZULIP_KEY="cKTDMZAPW08dk3zl05sStzO7HRztzyn8") - scripts/daily-infra-report.py:25 (was ZULIP_KEY="cKTDMZAPW08dk3zl05sStzO7HRztzyn8") Both now read from environment variable ZULIP_API_KEY (set by vault-backed start script) with loud failure if not present. Other credentials in scripts/: - capture-dsh-token.sh: uses TOKEN variable with fallback (not a secret) - pm2-self-heal.sh: reads TELEGRAM_BOT_TOKEN from /root/.pi/agent/extensions/telegram/.env (acceptable) - prose-ai-review.sh: uses GITEA_TOKEN from .env file with LITELLM_KEY fallback (not secrets) No other hardcoded credentials found. Proof of behavior: With ZULIP_API_KEY set: bash scripts/zulip-monitor.sh → Server: HTTP 200 (authenticated) python3 scripts/daily-infra-report.py --json → Collecting infrastructure data... Without ZULIP_API_KEY set: bash scripts/zulip-monitor.sh → "ZULIP_API_KEY not set — refusing to run with no credential" python3 scripts/daily-infra-report.py --json → "ZULIP_API_KEY not set — refusing to run with no credential" Cred source: environment variable ZULIP_API_KEY (set by vault-backed start script) No key rotation (that is a separate decision).