docs(agent-health): every check leg must appear in every report - a missing line is not a pass #111

Merged
abiba-bot merged 3 commits from fix/agent-health-mandatory-report-legs-20260917 into master 2026-09-17 03:12:58 +00:00
+31
View File
@@ -59,6 +59,37 @@ rules: any HTTP status = ALIVE; only 000/timeout/refused = probe-failed.
"Agent health check: OK". If `degraded` or `critical`, report the specific
failures and their severity.
**Mandatory report legs** (2026-09-17 decision, 1295.msg): Every report line
MUST include one clause per check leg, in every state: healthy, degraded/warn,
skipped, or failed. A missing leg must never look the same as a healthy leg.
Required legs and their templates in every state:
- `LiteLLM keys: 4/4 (tanko, abiba, koby, koonimo) valid`
- degraded: `LiteLLM keys: 2/4 (tanko valid; koby invalid; koonimo valid; abiba probe-failed: 192.168.68.116:4000 timeout)`
- skipped: `LiteLLM keys: SKIPPED (LiteLLM router unreachable)`
- `GPU ports: 3/3 (rtx3090, rtx5070, strixhalo) healthy`
- skipped: `GPU ports: SKIPPED (no SSH access to GPU hosts)`
- degraded/warn: `GPU ports: 2/3 (rtx3090 healthy; rtx5070 degraded: svc=inactive, port owned by 1234; strixhalo healthy)`
- failed: `GPU ports: 2/3 (rtx3090 healthy; rtx5070 probe-failed: 192.168.68.110:9400 timeout; strixhalo healthy)`
- The GPU leg has six non-healthy states the code can produce:
(i) `gpu-unreachable:{host}` — SSH probe failed;
(ii) `gpu-no-port:{label}` — SSH worked, port not listening;
(iii) `gpu-ghost:{label}:{pid}` — unit inactive, port owned by another pid;
(iv) unit not active, MainPID empty or port owned by MainPID — svc inactive;
(v) unit active, /health body contains "error" — error response;
(vi) unit active, /health body unrecognised — unknown health.
In every case the failing host and reason must be named.
- `CTs: 4/4 running (tanko, abiba, koby, koonimo)`
- degraded: `CTs: 3/4 (tanko running; abiba running; koby probe-failed: ssh root@192.168.68.129 timeout; koonimo running)`
- skipped: `CTs: SKIPPED (SSH access unavailable)`
- `Vault secrets: 3/3 present`
- degraded: `Vault secrets: 2/3 (tanko present; koby present; koonimo missing)`
- skipped: `Vault secrets: SKIPPED (vault not configured)`
The compact form in the summary line is acceptable (e.g. `rtx5070 timeout`) as
long as the host is identifiable from context; the full `probe-failed: <target>
<kind>` form is required when a leg reports a failure in the detail section.
### Probe Shape (per standing rules from 1150.msg)
1. **Any HTTP status means ALIVE.** 200, 301, 302, 401, 403, 404 all prove the