feat(proxmox-monitor): add PBS GC liveness signal #119

Merged

abiba-bot merged 4 commits from fix/pbs-gc-liveness-signal-20260919 into master 2026-09-19 02:51:35 +00:00

Conversation 0 Commits 4 Files Changed 3

+305

4 Commits

Author	SHA1	Message	Date
root	8ff13d38f3	docs(proxmox): Document all six PBS GC verdict shapes ... The Liveness Check section now documents ALL SIX verdict shapes exactly as emitted by proxmox-monitor.sh: 1. ✅ PBS GC: healthy (last run Nh ago, pending-bytes: N B) 2. 🔴 PBS GC: stale (last run Nh ago, pending-bytes: N B) 3. 🔴 PBS GC: probe-failed: storepve:192.168.68.6 (expected JSON, got 000) 4. 🔴 PBS GC: probe-failed: storepve:192.168.68.6 (unparseable JSON) 5. 🔴 PBS GC: never-run (storepve-datastore not found in GC list) 6. 🔴 PBS GC: never-run (storepve-datastore has no last-run-endtime) Fixed the quoted healthy example (line ~114) to include the pending-bytes suffix the code now appends. Previously the prose only documented the probe-failed shape, missing the PR's own headline cases (never-run). Proof: grep -n 'never-run' proxmox-monitor.prose.md now returns two lines (lines 106 and 108), documenting both never-run variants. Branch: fix/pbs-gc-liveness-signal-20260919	2026-09-19 02:43:49 +00:00
root	f59d1a2159	fix(proxmox): Fix PBS GC liveness leg + add comprehensive test suite ... (a) Probe-failure detection: now treats empty OR unparseable JSON as probe-failed, not never-run. This prevents 'command not found' outputs from being rendered as service verdicts. (b) pending-bytes: now extracted from JSON and reported in stale verdict. (c) Null endtime: use .get() with explicit None check, not 0 fallback. null values now correctly trigger never-run verdict instead of arithmetic crash (set -u). (d) Tests: Added 14-assertion stub-driven suite covering: healthy, stale (>48h), probe-failed (empty and unparseable), null endtime, datastore absent. Each test stubs ssh/curl to verify exact behavior against the pre-fix head. Branch: fix/pbs-gc-liveness-signal-20260919	2026-09-19 02:28:39 +00:00
root	da8f5f43c9	docs(proxmox): Add PBS GC documentation to proxmox-monitor.prose.md ... Document the PBS GC schedule (00:00 UTC, not 20:00 UTC as PR #116 said), what actually runs (pbs-gc.sh -> pct exec 107 -- proxmox-backup-manager), datastore location (CT 107's /mnt/pbs-backup on /tank/pbs-backup, NOT /media/easystore2), and the new liveness check (48h threshold, reports age in hours, explicit healthy line). Branch: fix/pbs-gc-liveness-signal-20260919	2026-09-19 02:12:17 +00:00
root	8ae4b59150	feat(proxmox): Add PBS GC liveness signal ... Add monitoring leg that checks storepve-datastore GC health: - Reads GC state from CT 107 via pct exec - FAILS if last-run-endtime is older than 48h - Reports age in hours and pending-bytes status - Uses JSON parsing for reliable data extraction Test: All 5 legs OK, Exit 0. Branch: fix/pbs-gc-liveness-signal-20260919	2026-09-19 02:04:05 +00:00