fix(litellm-health): run the key-list admin call on the gateway host, not inside the container #84

Merged
abiba-bot merged 1 commits from fix-litellm-health-registry-20260912 into master 2026-09-13 03:20:05 +00:00
Owner

Third pass on the same contract; the branch name is reused so master already contains the earlier commits and the three-dot diff is exactly one file.

The defect

Step 8 fetched /key/list with docker exec harness-litellm curl .... That container has no curl and no wget (command -v curl -> NO-CURL, wget -> NO-WGET), so the call emitted nothing; with stderr discarded the empty result was rendered as "0 agent keys" on every run. Live truth: 10 keys.

The fix

  • Step 8 now states the call runs on the CT 116 host (ssh root@192.168.68.116 "curl -s -H 'Authorization: Bearer $MASTER_KEY' http://127.0.0.1:4000/key/list"), with an explicit note that the container has no HTTP client.
  • An empty or unparseable response must report admin-call-failed, never "0 agent keys".

Verification

  • ssh root@192.168.68.116 "curl -s -H 'Authorization: Bearer <master>' http://127.0.0.1:4000/key/list" -> HTTP 200, 10 keys.
  • Container client check pasted as proof the old form could not work.
    Reviewers: re-run and paste the step-8 output and the key count you observe.
Third pass on the same contract; the branch name is reused so master already contains the earlier commits and the three-dot diff is exactly one file. ## The defect Step 8 fetched `/key/list` with `docker exec harness-litellm curl ...`. That container has **no curl and no wget** (`command -v curl` -> NO-CURL, wget -> NO-WGET), so the call emitted nothing; with stderr discarded the empty result was rendered as **"0 agent keys"** on every run. Live truth: 10 keys. ## The fix - Step 8 now states the call runs on the **CT 116 host** (`ssh root@192.168.68.116 "curl -s -H 'Authorization: Bearer $MASTER_KEY' http://127.0.0.1:4000/key/list"`), with an explicit note that the container has no HTTP client. - An empty or unparseable response must report `admin-call-failed`, never "0 agent keys". ## Verification - `ssh root@192.168.68.116 "curl -s -H 'Authorization: Bearer <master>' http://127.0.0.1:4000/key/list"` -> HTTP 200, **10 keys**. - Container client check pasted as proof the old form could not work. Reviewers: re-run and paste the step-8 output and the key count you observe.
abiba-bot added 1 commit 2026-09-13 03:16:19 +00:00
fix: litellm-health step 8 - run key/list on CT 116 host, not in container
PR Pipeline — Authorize → Validate → Review → Merge / auth (pull_request) Successful in 7s
PR Pipeline — Authorize → Validate → Review → Merge / validate (pull_request) Successful in 5s
PR Pipeline — Authorize → Validate → Review → Merge / lint (pull_request) Successful in 5s
PR Pipeline — Authorize → Validate → Review → Merge / ai-review (pull_request) Successful in 2s
PR Pipeline — Authorize → Validate → Review → Merge / gate (pull_request) Successful in 0s
edcf465831
- harness-litellm container has no curl/wget, so docker exec harness-litellm curl returns empty
- Fix: run curl on CT 116 host (ssh root@192.168.68.116 then curl)
- Add admin-call-failed label for empty/unparseable responses
- Verify: 10 keys found (host-side curl), NO-CURL confirmed in container
abiba-bot merged commit ef168d9690 into master 2026-09-13 03:20:05 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SyslogSolution/prose-contracts#84