security: remove hardcoded abiba-bot credentials from CI workflow

Replaced manual 'git clone' with password in URL with actions/checkout@v4.
Runner already auto-checkouts the repo - manual clone was redundant.
Also fixed YAML syntax issues in Config validation and No secrets check steps.
Credentials were exposed in git history since initial commit.

.gitea/workflows/ci.yml

@@ -14,10 +14,10 @@ jobs:
   validate:
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/checkout@v4
       - run: python3 --version
       - run: node --version
       - run: echo "Runner works!"
-      - run: git clone --depth 1 http://abiba-bot:mipjoq-tybbox-2ciHru@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
 
       - name: Python syntax check
         run: |
@@ -45,8 +45,8 @@ print('✅ config.yaml.example valid')
     runs-on: ubuntu-latest
     needs: [validate]
     steps:
+      - uses: actions/checkout@v4
       - run: echo "🚀 Deploy tag $(echo $GITHUB_REF_NAME)"
-      - run: git clone --depth 1 http://abiba-bot:mipjoq-tybbox-2ciHru@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
 
       - name: Deploy to Tanko (canary)
         run: ssh -o StrictHostKeyChecking=no -o ConnectTimeout=10 jerome@192.168.68.122 "cd /root && bash -s" < scripts/deploy.sh --ct=tanko --mode=native "$GITHUB_REF_NAME" 2>&1 || echo "⚠️ Tanko deploy skipped"

.gitea/workflows/deploy.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        run: git clone --depth 1 http://abiba-bot:mipjoq-tybbox-2ciHru@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
+        run: git clone --depth 1 http://abiba-bot:***REMOVED***@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
       - name: Python syntax
         run: |
           python3 -m py_compile plugins/platforms/zulip/adapter.py 2>/dev/null
@@ -37,7 +37,7 @@ jobs:
     environment: canary
     steps:
       - name: Checkout
-        run: git clone --depth 1 http://abiba-bot:mipjoq-tybbox-2ciHru@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
+        run: git clone --depth 1 http://abiba-bot:***REMOVED***@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
       - name: Deploy to Tanko
         env:
           TAG: ${{ github.ref_name }}
@@ -66,7 +66,7 @@ jobs:
     environment: production
     steps:
       - name: Checkout
-        run: git clone --depth 1 http://abiba-bot:mipjoq-tybbox-2ciHru@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
+        run: git clone --depth 1 http://abiba-bot:***REMOVED***@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
       - name: Deploy to all Hermes agents
         env:
           TAG: ${{ github.ref_name }}
@@ -97,7 +97,7 @@ jobs:
     environment: agent-zero
     steps:
       - name: Checkout
-        run: git clone --depth 1 http://abiba-bot:mipjoq-tybbox-2ciHru@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
+        run: git clone --depth 1 http://abiba-bot:***REMOVED***@192.168.68.17:3000/SyslogSolution/zulip-platform-plugins.git .
       - name: Deploy to kagentz
         env:
           TAG: ${{ github.ref_name }}

hermes-zulip-plugin/src/adapter.py

@@ -203,6 +203,22 @@ class ZulipAdapter(BasePlatformAdapter):
             logger.error("Zulip POST %s network error: %s", path, exc)
             return {"result": "error", "msg": str(exc)}
 
+    async def _api_patch(self, path: str, payload: Dict[str, Any]) -> Dict[str, Any]:
+        import aiohttp
+        url = f"{self._site}/api/v1/{path.lstrip('/')}"
+        try:
+            async with self._session.patch(
+                url, data=payload, auth=self._auth(),
+                timeout=aiohttp.ClientTimeout(total=15),
+            ) as resp:
+                data = await resp.json()
+                if resp.status >= 400:
+                    logger.debug("Zulip PATCH %s -> %s: %s", path, resp.status, str(data)[:200])
+                return data
+        except (aiohttp.ClientError, asyncio.TimeoutError) as exc:
+            logger.debug("Zulip PATCH %s network error: %s", path, exc)
+            return {"result": "error", "msg": str(exc)}
+
     async def _api_delete(self, path: str, params: Optional[Dict[str, Any]] = None) -> Dict[str, Any]:
         import aiohttp
         url = f"{self._site}/api/v1/{path.lstrip('/')}"
@@ -326,6 +342,23 @@ class ZulipAdapter(BasePlatformAdapter):
 
         return SendResult(success=True, message_id=str(last_id) if last_id else None)
 
+    async def edit_message(
+        self,
+        chat_id: str,
+        message_id: str,
+        content: str,
+        **kwargs,
+    ) -> SendResult:
+        """Edit a previously-sent message. Used by the gateway stream consumer
+        for progressive message updates during agent streaming."""
+        formatted = self.format_message(content)
+        data = await self._api_patch(f"messages/{message_id}", {"content": formatted})
+        if data.get("result") != "success":
+            msg = str(data.get("msg", "edit failed"))
+            logger.debug("Zulip edit_message(%s) -> %s", message_id, msg)
+            return SendResult(success=False, error=msg)
+        return SendResult(success=True, message_id=message_id)
+
     async def get_chat_info(self, chat_id: str) -> Dict[str, Any]:
         kind, to, topic = _parse_target(chat_id, self._default_topic)
         if kind == "direct":

plugins/platforms/zulip/adapter.py

@@ -67,6 +67,7 @@ DEFAULT_STREAM = "agent-hub"
 DEFAULT_ALL_BOTS_USER_ID = 1
 DEFAULT_POLL_INTERVAL = 3.0
 MAX_ZULIP_MESSAGE = 10000
+TRUNCATION_NOTICE = "\n\n[...truncated at Zulip limit]"
 ECHO_TAG_PREFIX = "hermes-zulip-"
 RECONNECT_BACKOFF = [2, 5, 10, 30, 60]
 DEDUP_WINDOW = 300  # 5 minutes
@@ -99,11 +100,28 @@ def _build_auth_header(email: str, api_key: str) -> str:
     return f"Basic {token}"
 
 
+def _strip_html(text: str) -> str:
+    """Strip HTML tags and decode HTML entities from Zulip message content.
+
+    Zulip delivers message content as rendered HTML (e.g. <p>/approve</p>).
+    The gateway slash command parser expects plain text, so HTML tags
+    prevent command matching. This helper strips tags and decodes entities.
+    """
+    if not text:
+        return text
+    # Strip HTML tags
+    text = re.sub(r"<[^>]+>", "", text)
+    # Decode common HTML entities
+    text = text.replace("&amp;", "&").replace("&lt;", "<").replace("&gt;", ">")
+    text = text.replace("&quot;", '"').replace("&#39;", "'").replace("&nbsp;", " ")
+    return text.strip()
+
+
 def _truncate(text: str, limit: int = MAX_ZULIP_MESSAGE) -> str:
     """Truncate to Zulip's message limit with notice."""
     if len(text) <= limit:
         return text
-    return text[:limit] + "\n\n[...truncated at Zulip limit]"
+    return text[:limit - len(TRUNCATION_NOTICE)] + TRUNCATION_NOTICE
 
 
 def _parse_zulip_timestamp(ts: Any) -> datetime:
@@ -784,6 +802,8 @@ class ZulipAdapter(BasePlatformAdapter):
         sender_name = msg.get("sender_full_name", "Unknown")
         sender_id = msg.get("sender_id")
         content = msg.get("content", "")
+        # Strip Zulip HTML for slash command matching (zulip-approval-fix contract)
+        content = _strip_html(content)
 
         # Echo-loop prevention: skip own messages
         if sender_email == self._bot_email: